# Looking for feedback on indicators i have selected to develop a trading algorithm

Hello everyone,
I am looking for feedback in developing a coherent set of indicators I can use together in order to develop a trading algorithm. i was looking to see if there is more than just ‘i like ___ indicator’ when putting an idea together. For example- i like the MFI, MACD, ADX, i also really like the RSI but since the MFI generates data similar to the RSI, i did not believe it would make much sense to include it. I also like the strategy of cross over (50d/200d MAs) and using Fibonnacci retracements to find S/R lines and make price predictions. I use these all separate to find entry/exit points.

I am in the algorithmic trading course right now, and for simplicity sake I am just looking to write a code to utilizing cross over trading strategy. However, i plan on developing a more advanced strategy in the future.

How did you guys all pick your indicators? ALSO- I’d like to add in that i plan to swing/position trade

@thecil Hello- my question hasn’t been answered yet and I was encouraged to tag you in the post.

You’ve really been busy doing research in trading .

Hey @cryptcat, hope you are ok.

Back when I was developing the strategy, I went a little bit further by adding the RSI indicator on my strategy, you can take it as example on how to add other indicators for it.

``````// This source code is subject to the terms of the Mozilla Public License 2.0 at https://mozilla.org/MPL/2.0/

//@version=4
strategy(title="Moving Average Crossing", overlay=true, initial_capital=2000, commission_type=strategy.commission.percent, commission_value=0.2)
//DATE & TIME
fromMonth = input(defval=1, title="From month", minval=1)
fromDay = input(defval=1, title="From day", minval=1)
fromYear = input(defval=2019, title="From year", minval=2014)
toMonth = input(defval=1, title="To month", minval=1)
toDay = input(defval=1, title="To day", minval=1)
toYear = input(defval=2025, title="To year", minval=2014)

//DEFINITIONS
shortMa = sma(close, 50)
longMa = sma(close, 200)
longCross = crossover(shortMa, longMa)
shortCross = crossover(longMa, shortMa)
max_risk = strategy.equity * 0.01
stoploss = 100
size = max_risk/stoploss

// Get RSI input
rsiSource = input(title="RSI Source", type=input.source, defval=close)
rsiLength = input(title="RSI Length", type=input.integer, defval=14)
rsiOverbought = input(title="RSI Overbought Level", type=input.integer, defval=80)
rsiOversold = input(title="RSI Oversold Level", type=input.integer, defval=20)
// Get RSI value
rsiValue = rsi(rsiSource, rsiLength)
isRsiOB = rsiValue >= rsiOverbought
isRsiOS = rsiValue <= rsiOversold

//LOGIC
timeInRange = (time > timestamp(fromYear, fromMonth, fromDay, 00, 00)) and (time < timestamp(toYear, toMonth, toDay, 23, 59))
longSignal = timeInRange and isRsiOB
shortSignal = timeInRange and isRsiOS

//CHART DRAW
plot(shortMa, color=color.orange)
plot(longMa, color=color.red)
plotshape(isRsiOB, title="Overbought", location=location.abovebar, color=color.red, transp=0, style=shape.triangledown, text="OB")
plotshape(isRsiOS, title="Oversold", location=location.belowbar, color=color.green, transp=0, style=shape.triangleup, text="OS")

//POSITIONS
strategy.entry(id="longPosition", long=true, qty=size, when=longSignal)
strategy.entry(id="shortPosition", long=false, qty=size, when=shortSignal)

strategy.exit("Exit Long", from_entry = "longPosition", loss = stoploss*100, profit = stoploss*200)
strategy.exit("Exit Short", from_entry = "shortPosition", loss = stoploss*100, profit = stoploss*200)
``````

This are some resources that i use to learn further for pinescript code:

Carlos Z